[FIX][fal]char设备类型补充缺失的入参，适配DFSv2框架 by AngryProton · Pull Request #11112 · RT-Thread/rt-thread

AngryProton · 2025-12-31T09:36:10Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

FAL的char类型设备结构体注册到DFSv2框架存在，实现函数与框架结构体的函数指针入参数量不齐的问题

你的解决方案是什么 (what is your solution)

通过DFSv2宏补齐DFSv2框架注册函数的入参数量

请提供验证的bsp和config (provide the config and bsp)

BSP:
.config:
action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

github-actions · 2025-12-31T09:36:19Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：fal_debug
设置PR number为 \ Set the PR number to：11112

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 fal_debug 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fal_debug branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions · 2025-12-31T09:36:22Z

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: Maihuanyi

Changed Files (Click to expand)

components/fal/src/fal_rtt.c

🏷️ Tag: components_fal

Reviewers: illustriousness

Changed Files (Click to expand)

components/fal/src/fal_rtt.c

📊 Current Review Status (Last Updated: 2026-01-05 13:52 CST)

⌛ Maihuanyi Pending Review
⌛ illustriousness Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Rbb666 · 2026-01-04T08:56:41Z

components/fal/src/fal_rtt.c

+#endif
 {
-    int ret = 0;
+    ssize_t ret = 0;


使用rt_ssize_t 吧

components/fal/src/fal_rtt.c

Rbb666 · 2026-01-04T08:58:05Z

components/fal/src/fal_rtt.c

-
-static int char_dev_fread(struct dfs_file *fd, void *buf, rt_size_t count)
+#ifdef RT_USING_DFS_V2
+static ssize_t char_dev_fread(struct dfs_file *fd, void *buf, size_t count, off_t *pos)


这块实现感觉使用#define写会好一些

#ifdef RT_USING_DFS_V2 #define ssize_t char_dev_fread(struct dfs_file *fd, void *buf, size_t count, off_t *pos) #else #define ssize_t char_dev_fread(struct dfs_file *fd, void *buf, size_t count) #endif

有点没明白，用#define的话，那后续编译过程中ssize_t会用char_dev_fread(struct dfs_file *fd, void *buf, size_t count, off_t *pos)去展开？

有点没明白，用#define的话，那后续编译过程中ssize_t会用char_dev_fread(struct dfs_file *fd, void *buf, size_t count, off_t *pos)去展开？
兼容dfsv1和dfsv2

dfsv1和dfsv2已经通过#ifdef RT_USING_DFS_V2实现

有点没明白，用#define的话，那后续编译过程中ssize_t会用char_dev_fread(struct dfs_file *fd, void *buf, size_t count, off_t *pos)去展开？

这样可读性会好一些

有点没明白，用#define的话，那后续编译过程中ssize_t会用char_dev_fread(struct dfs_file *fd, void *buf, size_t count, off_t *pos)去展开？

你可以看下这个代码的实现能不能明白：

https://github.com/RT-Thread/rt-thread/blob/master/bsp/renesas/libraries/HAL_Drivers/drivers/drv_sci.c#L26

是这部分定义吗？这个我能理解，因为R_SCI_SPI_Write和R_SCI_B_SPI_Write入参数量和类型相同，用宏去展开，代码可读性是会更好。

#ifdef R_SCI_B_SPI_H #define R_SCI_SPI_Write R_SCI_B_SPI_Write #define R_SCI_SPI_Read R_SCI_B_SPI_Read #define R_SCI_SPI_WriteRead R_SCI_B_SPI_WriteRead #define R_SCI_SPI_Open R_SCI_B_SPI_Open #define R_SCI_SPI_Close R_SCI_B_SPI_Close #define R_SCI_SPI_CallbackSet R_SCI_B_SPI_CallbackSet #endif

但目前的情况是dfsv1和dfsv2入参数量不一样，单纯从C编译的角度出发，我没get到修改建议的意图

#ifdef RT_USING_DFS_V2 #define ssize_t char_dev_fread(struct dfs_file *fd, void *buf, size_t count, off_t *pos) #else #define ssize_t char_dev_fread(struct dfs_file *fd, void *buf, size_t count) #endif

是这部分定义吗？这个我能理解，因为R_SCI_SPI_Write和R_SCI_B_SPI_Write入参数量和类型相同，用宏去展开，代码可读性是会更好。

#ifdef R_SCI_B_SPI_H #define R_SCI_SPI_Write R_SCI_B_SPI_Write #define R_SCI_SPI_Read R_SCI_B_SPI_Read #define R_SCI_SPI_WriteRead R_SCI_B_SPI_WriteRead #define R_SCI_SPI_Open R_SCI_B_SPI_Open #define R_SCI_SPI_Close R_SCI_B_SPI_Close #define R_SCI_SPI_CallbackSet R_SCI_B_SPI_CallbackSet #endif

但目前的情况是dfsv1和dfsv2入参数量不一样，单纯从C编译的角度出发，我没get到修改建议的意图

#ifdef RT_USING_DFS_V2 #define ssize_t char_dev_fread(struct dfs_file *fd, void *buf, size_t count, off_t *pos) #else #define ssize_t char_dev_fread(struct dfs_file *fd, void *buf, size_t count) #endif

哦哦我看错了，这样可以

[docs][libcpu][arm][cortex-a] add comment for mmu.h (RT-Thread#11104) * [docs][libcpu][arm][cortex-a] add comment for mmu.h * [docs][libcpu][arm][cortex-a] beautify comment for mmu.h * [docs][libcpu][arm][cortex-a] delete extra space at the end of lines [fix] drivers: spi: refactor SPI bit operations into independent configuration - Add RT_USING_SPI_BITOPS as a separate configurable option - Make RT_USING_SOFT_SPI depend on RT_USING_SPI_BITOPS - Adjust build order in SConscript for proper com Signed-off-by: Runcheng Lu <runcheng.lu@hpmicro.com> feat:[stm32][can]: Validate CAN filter bank settings and skip invalid items [add][RTduino] Fitter RTduino in frdm-mcxa346 (RT-Thread#11067) * add mcxa346-RTduino [FIX]Locking for dfs_dentry_dump must be consistent with that of all other dentry functions. fix(dfs): align fd API declarations with DFS_USING_POSIX [tools][cmake]:Fix the cmake creation error of scons [FIX][fal]char设备类型补充缺失的入参，适配DFSv2框架 (RT-Thread#11112) * [FIX][fal]补充缺失的入参，适配DFSv2框架 * [FIX][fal]正确声明入参的数据类型 * [chg]按审查建议修改变量类型和代码格式。

AngryProton and others added 2 commits December 31, 2025 14:09

[FIX][fal]补充缺失的入参，适配DFSv2框架

ac3f6cc

[FIX][fal]正确声明入参的数据类型

b196f4d

github-actions bot added the Component label Dec 31, 2025

AngryProton changed the title ~~Fal debug~~ [FIX][fal]补充缺失的入参，适配DFSv2框架 Dec 31, 2025

AngryProton changed the title ~~[FIX][fal]补充缺失的入参，适配DFSv2框架~~ [FIX][fal]char设备类型补充缺失的入参，适配DFSv2框架 Dec 31, 2025

Rbb666 reviewed Jan 4, 2026

View reviewed changes

[chg]按审查建议修改变量类型和代码格式。

c77e11a

Rbb666 approved these changes Jan 6, 2026

View reviewed changes

Rbb666 merged commit 3d8114b into RT-Thread:master Jan 6, 2026
56 of 57 checks passed

AngryProton deleted the fal_debug branch January 6, 2026 09:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FIX][fal]char设备类型补充缺失的入参，适配DFSv2框架#11112

[FIX][fal]char设备类型补充缺失的入参，适配DFSv2框架#11112
Rbb666 merged 3 commits intoRT-Thread:masterfrom
AngryProton:fal_debug

AngryProton commented Dec 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 31, 2025

Uh oh!

github-actions bot commented Dec 31, 2025 •

edited

Loading

Uh oh!

Rbb666 Jan 4, 2026

Uh oh!

Uh oh!

Rbb666 Jan 4, 2026 •

edited

Loading

Uh oh!

AngryProton Jan 4, 2026

Uh oh!

illustriousness Jan 4, 2026

Uh oh!

AngryProton Jan 5, 2026

Uh oh!

Rbb666 Jan 6, 2026

Uh oh!

Rbb666 Jan 6, 2026

Uh oh!

AngryProton Jan 6, 2026

Uh oh!

Rbb666 Jan 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

AngryProton commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions bot commented Dec 31, 2025

🛠 操作步骤 | Steps

Uh oh!

github-actions bot commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: components

🏷️ Tag: components_fal

📊 Current Review Status (Last Updated: 2026-01-05 13:52 CST)

📝 Review Instructions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Rbb666 Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AngryProton commented Dec 31, 2025 •

edited

Loading

github-actions bot commented Dec 31, 2025 •

edited

Loading

Rbb666 Jan 4, 2026 •

edited

Loading